Fix extracted files permissions
Fix #608: This commit fixes the extracted file permissions when using .extract/.extract_files in addition to when using the unpack cli command.
The fix is by overriding the _extract_member method of zip file, and adding permissions fix there.
The permissions fix was moved from the unpack to the new method.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 71.23%. Comparing base (
1e00742) to head (f3f09e5).
Additional details and impacted files
@@ Coverage Diff @@
## main #609 +/- ##
==========================================
+ Coverage 71.09% 71.23% +0.13%
==========================================
Files 13 13
Lines 1083 1088 +5
==========================================
+ Hits 770 775 +5
Misses 313 313
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Any plans to merge this? Anything I can do?
In what situation would this change ever be used? The WheelFile class in this library is not part of any public API.
In what situation would this change ever be used? The
WheelFileclass in this library is not part of any public API.
Ok, then. Your choice, I just thought you wanted this change, will close this PR.
Thanks for your work :)