virtualenv icon indicating copy to clipboard operation
virtualenv copied to clipboard

Change activation call to be a list of commands

Open kubouch opened this issue 2 years ago • 1 comments

ActivationTester will use a list of strings as the command instead of just a string.

Required to proceed with https://github.com/pypa/virtualenv/pull/2422

Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)!

  • [x] ran the linter to address style issues (tox -e fix_lint)
  • [x] wrote descriptive pull request text
  • [ ] ensured there are test(s) validating the fix
  • [x] added news fragment in docs/changelog folder
  • [ ] updated/extended the documentation

kubouch avatar Sep 25 '22 15:09 kubouch

@gaborbernat Is something like this what you had in mind?

kubouch avatar Sep 25 '22 15:09 kubouch

@gaborbernat Could you please comment whether this approach is what you had in mind when making the activation command a list of strings? Should I continue debugging it to make it work on Windows or is it something else you meant? Reference conversation: https://github.com/pypa/virtualenv/pull/2422#discussion_r973625771

kubouch avatar Oct 15 '22 08:10 kubouch

Yeah you are on the right path.

gaborbernat avatar Oct 15 '22 14:10 gaborbernat

@kubouch updates on this?

gaborbernat avatar Oct 25 '22 05:10 gaborbernat

I didn't have time to investigate the Windows issue because I had to focus on my actual work but I'd like this to be finished. If you have an idea why it's failing on Windows, that would help a lot.

kubouch avatar Oct 25 '22 08:10 kubouch

Not sure sadly.

gaborbernat avatar Oct 25 '22 15:10 gaborbernat

Seems no longer needed.

gaborbernat avatar Nov 27 '22 18:11 gaborbernat

OK, so the activation command being a list is no longer necessary?

kubouch avatar Nov 27 '22 18:11 kubouch

Would still be nice to make the change, but seems we can't get it working 👍

gaborbernat avatar Nov 27 '22 18:11 gaborbernat

Yeah, it's something related to the Windows paths but I couldn't locate the issue.

kubouch avatar Nov 27 '22 18:11 kubouch