virtualenv
virtualenv copied to clipboard
Change activation call to be a list of commands
ActivationTester will use a list of strings as the command instead of just a string.
Required to proceed with https://github.com/pypa/virtualenv/pull/2422
Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)!
- [x] ran the linter to address style issues (
tox -e fix_lint
) - [x] wrote descriptive pull request text
- [ ] ensured there are test(s) validating the fix
- [x] added news fragment in
docs/changelog
folder - [ ] updated/extended the documentation
@gaborbernat Is something like this what you had in mind?
@gaborbernat Could you please comment whether this approach is what you had in mind when making the activation command a list of strings? Should I continue debugging it to make it work on Windows or is it something else you meant? Reference conversation: https://github.com/pypa/virtualenv/pull/2422#discussion_r973625771
Yeah you are on the right path.
@kubouch updates on this?
I didn't have time to investigate the Windows issue because I had to focus on my actual work but I'd like this to be finished. If you have an idea why it's failing on Windows, that would help a lot.
Not sure sadly.
Seems no longer needed.
OK, so the activation command being a list is no longer necessary?
Would still be nice to make the change, but seems we can't get it working 👍
Yeah, it's something related to the Windows paths but I couldn't locate the issue.