setuptools_scm icon indicating copy to clipboard operation
setuptools_scm copied to clipboard

Apply ruff/flake8-implicit-str-concat rule ISC001

Open DimitriPapadopoulos opened this issue 1 year ago • 2 comments
trafficstars

https://docs.astral.sh/ruff/rules/single-line-implicit-string-concatenation/

DimitriPapadopoulos avatar May 06 '24 21:05 DimitriPapadopoulos

At first glance all occurences where intentionally line split and had gotten cobbled to a single line, i think multi line Strings are needed

RonnyPfannschmidt avatar May 06 '24 21:05 RonnyPfannschmidt

This is the result of applying black in #255, and ruff format will again fold the multiple lines into a single line — unless the code is enclosed in # fmt: off and # fmt: on.

Would you rather add # fmt: directives?

DimitriPapadopoulos avatar May 06 '24 21:05 DimitriPapadopoulos

I think real multi line Strings should be used

RonnyPfannschmidt avatar May 07 '24 11:05 RonnyPfannschmidt

I'll try to do that with # fmt.

DimitriPapadopoulos avatar May 07 '24 11:05 DimitriPapadopoulos

what i meant was using tripple quote string, not disabling fmt

RonnyPfannschmidt avatar May 07 '24 11:05 RonnyPfannschmidt

thanks!

RonnyPfannschmidt avatar May 15 '24 19:05 RonnyPfannschmidt