Enforce ruff/refurb rules (FURB)

Open DimitriPapadopoulos opened this issue 1 year ago • 4 comments

Summary of changes

Follow-up of #4172.

Pull Request Checklist

[ ] Changes have tests
[ ] News fragment added in newsfragments/. (See documentation for details)

May 23 '24 07:05 DimitriPapadopoulos

Looks like you're missing imports for operator

Aug 19 '24 07:08 Avasam

I think I mistakenly removed the imports while rebasing. Should be fixed now.

Aug 19 '24 09:08 DimitriPapadopoulos

@DimitriPapadopoulos I think you're missing a ruff.toml change adding FURB

Jan 03 '25 07:01 Avasam

Now that this is back to being a simpler PR. @abravalheri / @jaraco refurb would also have been one of my suggestions with improvements in readability and simplifications.

Jan 03 '25 20:01 Avasam

Rebased.

May 23 '25 08:05 DimitriPapadopoulos

The Python 3.14 CI errors might be related to https://github.com/python/cpython/issues/133653.
Not sure about the PyPy 3.10 CI error, but it seems unrelated to this PR as well.

May 23 '25 08:05 DimitriPapadopoulos