sampleproject icon indicating copy to clipboard operation
sampleproject copied to clipboard

Error in ppg_sqi.use_template(wave, annotation: list, fs: int)

Open HotDog702 opened this issue 1 year ago • 1 comments

94:    locs = find_peaks(y[i:])[0]
95:    pks = y[locs]

find_peaks returns peak indexes relative to the beginning of input array, in your case y[i:], so to get peak indexes of the original array, you have to add the index of starting point, namely i. So, correct line must be: 94: locs = find_peaks(y[i:])[0] + i otherwise the next line returns incorrect pks values OR: 95: pks = y[i:][locs]

By the way, you can get peak values directly from find_peaks by transferring to it height= parameter

HotDog702 avatar Nov 08 '24 09:11 HotDog702

Hi @HotDog702 please note that this repository is simply a template and does not implement any of the functions you mentioned.

What is probably happening is that the library you are using started as a clone of this template and forgot to modify the github link to its own repo.

My recommendation is to try to find out what is the issue tracker for the specific library you are using and post the issue there.

abravalheri avatar Nov 08 '24 15:11 abravalheri