It's good as a skeleton example, but...

[ymoran00]

... is it possible to add actual py files in the packages to see how their import statements look? I'm not sure in case of namespaces if the import includes the namespaces, if it includes the package names, etc...

[theacodes]

Hi @ymoran00, can you expand a bit on what you're looking for?

[n1ckdm]

Hi @theacodes, if I've understood @ymoran00 correctly then it would be useful to put some modules inside the example and potentially some a setup.py file. In the documentation the folder structure that they use to explain the concepts is:

mynamespace-subpackage-a/
    setup.py
    mynamespace/
        subpackage_a/
            __init__.py

mynamespace-subpackage-b/
    setup.py
    mynamespace/
        subpackage_b/
            __init__.py
        module_b.py

Including a more concrete example that follows the documentation would make it easier for people (like myself) who are new to packaging and deployment understand the concepts and how to implement them.

[theacodes]

I'm up for that if someone wants to send a PR.

On Thu, May 9, 2019 at 1:53 AM Nick [email protected] wrote:

Hi @theacodes https://github.com/theacodes, if I've understood @ymoran00 https://github.com/ymoran00 correctly then it would be useful to put some modules inside the example and potentially some a setup.py file. In the documentation the folder structure that they use to explain the concepts is:

mynamespace-subpackage-a/ setup.py mynamespace/ subpackage_a/ init.py

mynamespace-subpackage-b/ setup.py mynamespace/ subpackage_b/ init.py module_b.py

Including a more concrete example that follows the documentation would make it easier for people (like myself) who are new to packaging and deployment understand the concepts and how to implement them.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pypa/sample-namespace-packages/issues/13#issuecomment-490817416, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB5I46MXBGYJM2CHQTTAA3PUPQ7DANCNFSM4HECOF6Q .