pipenv icon indicating copy to clipboard operation
pipenv copied to clipboard

Was v2023.11.17 mistagged?

Open rittneje opened this issue 5 months ago • 4 comments

I'm assuming that pipenv is using date-based versioning, in which case I would have expected the latest release to be v2024.01.21 not v2023.11.17. Is there some reason for this discrepancy?

rittneje avatar Feb 01 '24 13:02 rittneje

No, we are switching to semver. https://github.com/pypa/pipenv/discussions/6014

matteius avatar Feb 01 '24 15:02 matteius

I initially thought the most recent release version was broken too, until I found this issue.

Would it be possible to say bump the version to a visibly-not-a-real-date version (eg 3000.Y.Z) in the next release, to reduce the chance for confusion?

edmorley avatar Feb 01 '24 22:02 edmorley

Also I think a clearer explicit call-out at the top of the release notes would be helpful: https://github.com/pypa/pipenv/releases/tag/v2023.11.17

Currently the only mention is this:

Update release script to enforce semver going forward in 2024

...which (a) requires quite a bit of reading between the lines to understand the impact, (b) was in the middle of a number of other changelog entries, rather than being called out at the top in an intro paragraph etc.

edmorley avatar Feb 01 '24 22:02 edmorley

We can do the major 3000 thing when we do our next major version release (have some install API changes planned and same for uninstall), but until then it's going to be based off the incrementing off the current version.

Also I don't curate the Changelog, its auto-generated. I also provided the Discussion topic some weeks ago.

matteius avatar Feb 01 '24 23:02 matteius