pipenv
pipenv copied to clipboard
Add Python 3.11 release candidate to the testing
On macOS:
============================= test session starts ==============================
platform darwin -- Python 3.11.0rc1, pytest-7.1.2, pluggy-1.0.0
[ ... ]
FAILED tests/integration/test_cli.py::test_pipenv_graph - assert 1 == 0
FAILED tests/integration/test_cli.py::test_pipenv_graph_reverse - assert 1 == 0
FAILED tests/unit/test_utils.py::test_convert_deps_to_pip[deps0-requests] - A...
FAILED tests/unit/test_utils.py::test_convert_deps_to_pip[deps1-requests[socks]]
===== 4 failed, 278 passed, 18 skipped, 21 warnings in 1704.26s (0:28:24) ======
Thank you for contributing to Pipenv!
The issue
What is the thing you want to fix? Is it associated with an issue on GitHub? Please mention it.
Always consider opening an issue first to describe your problem, so we can discuss what is the best way to amend it. Note that if you do not describe the goal of this change or link to a related issue, the maintainers may close the PR without further review.
If your pull request makes a non-insignificant change to Pipenv, such as the user interface or intended functionality, please file a PEEP.
https://github.com/pypa/pipenv/blob/master/peeps/PEEP-000.md
The fix
How does this pull request fix your problem? Did you consider any alternatives? Why is this the best solution, in your opinion?
The checklist
- [ ] Associated issue
- [ ] A news fragment in the
news/
directory to describe this fix with the extension.bugfix
,.feature
,.behavior
,.doc
..vendor
. or.trivial
(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.
https://github.com/pypa/pipenv/pull/5343#issuecomment-1240825697
Hi
In https://github.com/pypa/pipenv/pull/5343#issuecomment-1241083067 you mentioned:
This will need to wait until pytest v7.2.0 pytest-dev/pytest#9982
pytest 7.2.0 has now been released: https://github.com/pytest-dev/pytest/releases/tag/7.2.0
Also, Python 3.11.0 was released last night, and testing locally with pipenv 2022.10.12, I get the following RuntimeWarning
:
.../lib/python3.11/site-packages/pipenv/vendor/attr/_make.py:876: RuntimeWarning: Running interpreter doesn't sufficiently support code object introspection. Some features like bare super() or accessing __class__ will not work with slotted classes.
set_closure_cell(cell, cls)
This is coming from the attr
package, which was fixed in v22.1.0 (https://github.com/python-attrs/attrs/commit/a18b3957d55c669de56799a9a72ea31febe93ce4) however pipenv is still using v21.2.0:
https://github.com/pypa/pipenv/blob/v2022.10.12/pipenv/vendor/vendor.txt#L2
As such, attr
will need bumping too, as well as pytest.
Thanks, Ed
- [x]
vendor.txt: Upgrade to attrs==22.1.0
- [ ] Where is the version of pytest specified?
For attr
, I believe the vendored copy also needs updating by running the command mentioned here:
https://github.com/pypa/pipenv/blob/main/pipenv/vendor/README.md
Where is the version of pytest specified?
I'm guessing it's maybe pulled in implicitly via one of the pytest-*
deps here?
https://github.com/pypa/pipenv/blob/cb9d87ad05830449743cbc3ffa09ebbc7cca602d/Pipfile#L6-L21
Maybe refreshing this repo's Pipfile.lock
will be sufficient to pick up the 7.2.0 update?
@cclauss Several vendored dependencies (including attr
) have now been updated on main
. Could you rebase on main
to pick up those changes? After that, I would recommend running pipenv lock
to refresh this repo's Pipfile.lock
, since hopefully the pytest update will resolve the other issues :-)
@oz123 HI! I don't suppose you have a spare moment to review/merge this? :-)