pipenv icon indicating copy to clipboard operation
pipenv copied to clipboard

Wexpect trial

Open matteius opened this issue 3 years ago • 1 comments

Thank you for contributing to Pipenv!

The issue

Trying to get some improved windows support and figure out why those 3 tests are failing in the CI.

The fix

How does this pull request fix your problem? Did you consider any alternatives? Why is this the best solution, in your opinion?

Not sure if it does.

The checklist

  • [ ] Associated issue
  • [ ] A news fragment in the news/ directory to describe this fix with the extension .bugfix, .feature, .behavior, .doc. .vendor. or .trivial (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

matteius avatar Jul 05 '22 23:07 matteius

We have to think on conditionally vendoring this module on Windows only packages. Otherwise, everyone has this vendored regardless of the OS.

oz123 avatar Jul 06 '22 19:07 oz123

Nothing really indicates to me that this is necessary.

matteius avatar Aug 13 '22 14:08 matteius