pipenv icon indicating copy to clipboard operation
pipenv copied to clipboard

Looking for maintainers

Open frostming opened this issue 3 years ago • 27 comments

This project is used by millions of people, but the number of contributions is not on par with the issues number. I am a bit burnt out by the bugs reports with the limited time of my open source as most of it has been devoted to PDM. I have been waiting for someone to pick up those issues but few show up. So I opened this issue to see if anyone is interested in maintaining it, please leave a comment below and I will add you to the members list.

Any contributions, including but not limited to issue triaging, bug fixing, and feature improvements are welcome. I am glad to offer help of any type.

frostming avatar Dec 14 '21 08:12 frostming

Wow. So sorry to hear that issues are building up and that you're getting overwhelmed. We definitely use pipenv but recently accessing private repository resources has been challenging. Would love to promote it amongst the team of course. I'm curious to know what priorities you have for the project to move it forward?

henrytseng avatar Dec 16 '21 00:12 henrytseng

Just a month ago I started a new job and we use pipenv. I like the project and it solves a problem of automating locking package versions and documenting their known hash values for validation at install time, which has major security benefits over your basic requirements files. We ran into an issue with the new versions published in November basically dropping 75% of the lock file based on the Pipenv file. I intend to investigate that further as a starting point, and not sure how much time I'll have overall, but would be happy to lend a hand where I can.

matteius avatar Dec 18 '21 07:12 matteius

@matteius Thank you for your effort triaging issues, I've added you as a co-maintainer, feel free to close invalid ones.

frostming avatar Dec 18 '21 09:12 frostming

How exciting! :-) Thanks for your trust @frostming, I will do my best and begin slow--looks like is a lot of potential to trim it down over the next months.

matteius avatar Dec 18 '21 09:12 matteius

I'm hoping I'll be able to find some time to look into a few bugs too.

mattalxndr avatar Dec 19 '21 04:12 mattalxndr

Thanks to your effort to maintain this project @frostming. I like this project and can take a role for maintaining.

kobayashi avatar Dec 22 '21 22:12 kobayashi

@mattalexx @kobayashi , thank you. You can just start contributing and I will add you to the maintainers at a suitable time.

frostming avatar Dec 23 '21 04:12 frostming

@frostming I maybe have time to fix some bugs during a transition time. I do not have time to be an official maintainer.

mattalxndr avatar Dec 23 '21 05:12 mattalxndr

Hi @frostming, I just saw your issue regarding the needs maintainer for this project. It would be great to contribute to this project. Because I had used it in a couple of projects and It will be a great honor for me to contribute to this open-source project. Please let me know how can I start because it will be my first experience contributing to an open-source community. Regards: Faizan AlHassan

faizanalhassan avatar Dec 29 '21 09:12 faizanalhassan

Hi, @mattalexx @faizanalhassan Thank you for the interest, you can start by triaging issues and answering questions in the Issues backlog. Fixing bugs would be more appreciated.

frostming avatar Dec 30 '21 01:12 frostming

I'm using pipenv on a day to day basis and thinks it makes work related to application dependensies easier both for developers and educators. I'm sorry to hear about your availability issues but can understand. While not having the availability to play a role as a maintainer, contributing to bug fixes for pipenv will definitely be one of my goal for the coming year. I quasi daily refer students to https://packaging.python.org/en/latest/tutorials/managing-dependencies/ and would be happy to contribute the stabilisation of the tool.

Kind regards, Thierry

tchappui avatar Dec 31 '21 15:12 tchappui

Hi, I have been maintaining the Gentoo ebuild for quite a while and I'm familiar with the code base. IMHO, I can contribute in the following areas:

  • Code clean up.
  • documentation updates
  • testing

oz123 avatar Jan 09 '22 12:01 oz123

I'm down to figure out how to make a release next.

matteius avatar Mar 12 '22 09:03 matteius

Also for anyone else looking to help out, the Documentation label might be a good place to start for a first PR: https://github.com/pypa/pipenv/issues?q=is%3Aissue+is%3Aopen+label%3A%22Type%3A+Documentation+%3Abook%3A%22

Also we have a number of open PRs from yours truly, and some other contributors that if you could have a look at and add feedback on would be useful. If you are feeling more ambitious the backlog of issues are finding themselves with mostly accurate labels these days.

matteius avatar Mar 12 '22 10:03 matteius

@frostming You might want to pin this issue. :)

pradyunsg avatar Mar 22 '22 11:03 pradyunsg

@pradyunsg unfortunately only he can pin it. But @matteius and myself are already very active.

oz123 avatar Mar 22 '22 11:03 oz123

Well, I can do it as well -- so I've done that.

If y'all aren't looking for more maintainers, please say so and I'll unpin this. Let me know if there's folks with the write bit here who aren't members of the PyPA -- I'll add them in with write bit and to pypa-committers so that they get the ability to vote in the PyPA committer votes (see PEP 609). :)

pradyunsg avatar Mar 22 '22 12:03 pradyunsg

Please add myself and @matteius, also we kind of have strange permissions here. We can push and merge, but we can't add new contributors. @frostming isn't always active. Also, pipenv depends on many projects from https://github.com/sarugaku, but it seems abandoned. My efforts to contact the maintainers haven't been answered. We can fork the repositories, but we still lack permission on PyPI can this somehow be resolved via PyPA?

oz123 avatar Mar 22 '22 12:03 oz123

For sarugaku, I am not able to add you as a member, but I can add you as collaborator for specific projects. @uranusjr can help.

frostming avatar Mar 22 '22 12:03 frostming

@frostming thanks for the quick response. I'll need to revisit which projects we needed patch. @matteius is leading this, I'm helping on slack and reviews.

oz123 avatar Mar 22 '22 12:03 oz123

@frostming Its requirementslib and pip-shims that is currently blocking the update to pip 22.0.4 which solves a number of resolver issues for people. If we could get collaborator to those would be a big help.

@pradyunsg I would like to by added as a member of pypa and I suspect so would @oz123 -- Thanks for pinning this issue; I have been enjoying taking on a maintenance role for the project, however having more peer reviewers and folks triaging issues would be helpful in general. As we try to clean some more things up here and always good to have more support rather than less.

matteius avatar Mar 22 '22 20:03 matteius

@frostming Its requirementslib and pip-shims that is currently blocking the update to pip 22.0.4 which solves a number of resolver issues for people. If we could get collaborator to those would be a big help.

I've sent the invitation

frostming avatar Mar 23 '22 01:03 frostming

Please drop a word if you're interested in a sarugaku project. I don't maintain all of them either but we could work out a solution if needed; what exactly needs to be done depends on which one of them you wish to work on.

--

Edit: Oh I see you mentioned the projects specifically in a later comment and Frost already handled them. Please do keep me posted if you need further help.

uranusjr avatar Mar 23 '22 05:03 uranusjr

I have been using pipenv for several months and created several open source projects and have contributed to various projects such as django, pydantic, and mypy stubs. It would be great if i could contribute even a small help.

xncbf avatar Mar 29 '22 04:03 xncbf

Thanks to all, now we have a very active maintainer @matteius, and @oz123 as a reviewer. I will proceed to unpin this issue now. Anyone who drops in and is interested, welcome to contribute.

frostming avatar Mar 29 '22 04:03 frostming

@uranusjr or @pradyunsg or @frostming Would it be possible add myself https://pypi.org/user/matteiuspi/ (I set up MFA on my account) and @oz123 to the maintainers in pypi and if someone could get a review of the current list? I know that I don't really recognize the name tuxtimo or JetBlackPope in my 5 months contributing to the project.

matteius avatar Apr 21 '22 04:04 matteius

I don’t have permission to add user on PyPI unfortunately. Both users you mentioned stopped contributing to pipenv for quite a while (one or two years iirc); it’s probably safe to keep them but I wouldn’t object if someone wants to take them off. We should ask them first though.

uranusjr avatar Apr 21 '22 10:04 uranusjr

I've finally invited a bunch of the relevant pipenv maintainers to the pypa GitHub organisation as members. To those that got an invite, please accept it and then remove yourself from https://github.com/pypa/pipenv/settings/access (don't remove pipenv-committers).

pradyunsg avatar May 08 '23 07:05 pradyunsg