pipenv icon indicating copy to clipboard operation
pipenv copied to clipboard

Rewrote sentences to increase clarity

Open acdoc opened this issue 6 years ago • 3 comments

Also reduced hedging

Thank you for contributing to Pipenv!

The issue

What is the thing you want to fix? Is it associated with an issue on GitHub? Please mention it.

Always consider opening an issue first to describe your problem, so we can discuss what is the best way to amend it. Note that if you do not describe the goal of this change or link to a related issue, the maintainers may close the PR without further review.

If your pull request makes a non-insignificant change to Pipenv, such as the user interface or intended functionality, please file a PEEP.

https://github.com/pypa/pipenv/blob/master/peeps/PEEP-000.md

The fix

How does this pull request fix your problem? Did you consider any alternatives? Why is this the best solution, in your opinion?

The checklist

  • [ ] Associated issue
  • [ ] A news fragment in the news/ directory to describe this fix with the extension .bugfix, .feature, .behavior, .doc. .vendor. or .trivial (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

acdoc avatar Mar 20 '19 23:03 acdoc

The changes look good to me. Would you mind adding a file at news/3635.doc describing this change?

uranusjr avatar Mar 22 '19 15:03 uranusjr

@acdoc Hope my suggestion is helpful. And, as @uranusjr mentioned, please add a news fragment.

brainwane avatar Mar 31 '20 15:03 brainwane

Noting that we should adopt these changes to a new branch based on latest main and add a news fragment. Then we can close out this PR at that time.

matteius avatar Jul 06 '22 05:07 matteius