pip icon indicating copy to clipboard operation
pip copied to clipboard

req: Add warning of not recording VCS info with legacy 'setup.py install'

Open NoahGorny opened this issue 5 years ago • 8 comments

Closes #9176

NoahGorny avatar Dec 02 '20 23:12 NoahGorny

@uranusjr I rebased this to latest master, but I think this can be merged

NoahGorny avatar Jan 22 '21 21:01 NoahGorny

I'm waiting for a second opinion if possible.

uranusjr avatar Jan 22 '21 22:01 uranusjr

Let's leave it until after the release this weekend, in that case.

pfmoore avatar Jan 22 '21 22:01 pfmoore

I'm not 100% convinced this the right place to warn users about this, as this will show a warning for users that may not care about pip freeze at all.

There is also REQUESTED that is not generated in this case.

Also, the setup.py install code path will be called out systematically when #9422 and #8560 are complete, so we might want to rather make it a more generic warning that some features may not work perfectly when the legacy setup.py install is used.

Regarding freeze, we could detect legacy installed distributions when running pip freeze and warn about those there ?

sbidoul avatar Jan 24 '21 14:01 sbidoul

Regarding freeze, we could detect legacy installed distributions when running pip freeze and warn about those there?

Is it possible/easy to detect an setup.py install-ed distribution apart from a wheel-installed one? Does the format guaranteed to be a .egg-info, for example?

uranusjr avatar Jan 25 '21 01:01 uranusjr

Or can we assume the presence of .dist-info means the installation is standards-based ?

sbidoul avatar Jan 25 '21 08:01 sbidoul

We should probably add a test to ensure that this warning is printed.

Addded :smile:

NoahGorny avatar Mar 03 '21 21:03 NoahGorny

To communicate with sufficient clarity: I do not intend to block the 21.3 release on this PR, since this doesn't seem to be a show-stopper issue; even though this would be a nice-to-have improvement!

To that end, I've gone ahead and dropped this from the release milestone. :)

pradyunsg avatar Oct 02 '21 11:10 pradyunsg

Going to go ahead and close this, since it has merge conflicts that haven't been resolved in a while.

Please feel welcome to file a new PR or to reopen and update this one (assuming that's what the existing discussions point toward)!

pradyunsg avatar Sep 30 '22 13:09 pradyunsg