pip icon indicating copy to clipboard operation
pip copied to clipboard

Run Windows CI across all supported Python versions

Open ichard26 opened this issue 1 year ago • 3 comments

Let's see how slow or not slow this is...

This still needs updates to the development documentation.

ichard26 avatar Oct 13 '24 23:10 ichard26

They're on par with the rest of the CI jobs. This should be okay to deploy. PTAL.

ichard26 avatar Oct 20 '24 00:10 ichard26

My only reservation would be that the probability of failure in those jobs (that would not also be revealed by the linux jobs) is so low that it may not be worth the additional heating of the planet.

sbidoul avatar Oct 20 '24 16:10 sbidoul

My only reservation would be that the probability of failure in those jobs (that would not also be revealed by the linux jobs) is so low that it may not be worth the additional heating of the planet.

Following this logic, shouldn't everything that isn't latest/oldest be turned off other than macos-latest? Which seems to be the fastest of all the CI jobs.

Then all the other Python versions can be run on a schedule, like in https://github.com/pypa/pip/pull/13014.

My only strong opinion here is that all versions of Python for all supported OSes should be tested before a release. OS-Python version specific issues do come up with pip.

notatallshaw avatar Oct 20 '24 18:10 notatallshaw

I'm going to (cheekly) put this on to the 25.0 milestone, so this approach can be accepted or rejected by then, discussion was here: https://github.com/pypa/pip/issues/13011

notatallshaw avatar Nov 10 '24 20:11 notatallshaw

OS-Python version specific issues do come up with pip.

Do we know a case where, say, tests pass on all platforms on python 3.8 and 3.13, but fail on an intermediate version only on a specific platform ?

If not I would not do this for the reason in https://github.com/pypa/pip/pull/13016#issuecomment-2425118959

sbidoul avatar Jan 12 '25 14:01 sbidoul

Do we know a case where, say, tests pass on all platforms on python 3.8 and 3.13, but fail on an intermediate version only on a specific platform ?

We've had at least one case of that but I can't find it (although IIRC it was a problem with the actions/setup-python action as one of the Windows job were failing with path too long errors despite long paths being enabled). I can't find anything else using GitHub search.

I would be fine with just running the full Windows CI on a weekly basis. I don't feel particularly strongly about this.

ichard26 avatar Jan 12 '25 15:01 ichard26

Ok, I'm removing this from the release milestone since this can be done independently of any release.

sbidoul avatar Jan 12 '25 15:01 sbidoul

Sounds good :)

ichard26 avatar Jan 12 '25 15:01 ichard26

I don't see any urgency to change things here. I don't think this is likely to make a significant difference to how many bugs we catch with CI, and while we're not in the same league as AI training when it comes to compute usage, keeping our power expenditure even a little lower seems worthwhile.

pfmoore avatar Jan 12 '25 17:01 pfmoore

Closing in favour of #13191. Thanks for the discussion folks!

ichard26 avatar Jan 29 '25 17:01 ichard26