pip icon indicating copy to clipboard operation
pip copied to clipboard

Enforce ruff/pyupgrade rules (UP)

Open DimitriPapadopoulos opened this issue 1 year ago • 1 comments

As part of repo-review suggestions:

https://learn.scientific-python.org/development/guides/repo-review/?repo=pypa%2Fpipx&branch=main

DimitriPapadopoulos avatar Aug 24 '24 18:08 DimitriPapadopoulos

FWIW, enabling pyupgrade rules by default was discussed and the sentiment appeared to be to run it on an ad-hoc basis not to enforce it: https://github.com/pypa/pip/pull/11944#issuecomment-1950277239

notatallshaw avatar Aug 24 '24 19:08 notatallshaw

FWIW, enabling pyupgrade rules by default was discussed and the sentiment appeared to be to run it on an ad-hoc basis not to enforce it: #11944 (comment)

Would you like me to remove UP from the selected ruff rules?

DimitriPapadopoulos avatar Sep 16 '24 19:09 DimitriPapadopoulos

Would you like me to remove UP from the selected ruff rules?

I'm personally supportivel of UP being a selected rule set, and turning off any particular rules if they're found to be problematic. But pip maintainers may have different opinions (as linked).

notatallshaw avatar Sep 16 '24 19:09 notatallshaw