pip icon indicating copy to clipboard operation
pip copied to clipboard

Published 20 hours ago • verified publisher icon pypa

Upgrade truststore to 0.9.1

Open sethmlarson opened this issue 1 year ago • 1 comments

Follow-up from https://github.com/pypa/pip/pull/12662 which fixes the issue discovered after 0.9.0 was vendored (thanks @notatallshaw for reporting that issue!)

sethmlarson avatar May 17 '24 20:05 sethmlarson

Thank you for the review @uranusjr!

sethmlarson avatar May 20 '24 19:05 sethmlarson

@sethmlarson Could you rebase/merge in main to pull in the CI fixes?

ichard26 avatar Jun 01 '24 18:06 ichard26

@ichard26 Done!

sethmlarson avatar Jun 02 '24 15:06 sethmlarson

Strange that pre-commit CI is failing, but could you also fix that? (I would fix it myself, but I'm not a pip committer and I can't push to your branch, sorry.)

ichard26 avatar Jun 02 '24 17:06 ichard26

@ichard26 Fixed the issue and repushed, sorry for that!

sethmlarson avatar Jun 02 '24 17:06 sethmlarson

To committers, any objections if this lands for 24.1 final? This was supposed to be in the release, but undiscovered Python 3.13 incompatibilities led to a revert. If it's too risky, I'd like to see this land in 24.2.

ichard26 avatar Jun 03 '24 02:06 ichard26

@ichard26 @uranusjr Is there anything else that needs doing before this is merged?

sethmlarson avatar Jun 13 '24 20:06 sethmlarson

That would be up to @pradyunsg who is the release manager for 24.1. Given we're on our 2nd beta and we're approaching the final release, it may be too risky to land this change. Is this vendoring bump necessary for Python 3.13 support?

ichard26 avatar Jun 15 '24 21:06 ichard26

@ichard26 Unfortunately so, the pull request that fixes the issue upstream hasn't been merged: https://github.com/python/cpython/pull/118669

sethmlarson avatar Jun 17 '24 14:06 sethmlarson

I will schedule this for 24.1 so @pradyunsg will take a look at this, but it's up to them to decide whether this goes in or not.

ichard26 avatar Jun 17 '24 20:06 ichard26