pip
pip copied to clipboard
Deprecate --install-options
Towards #8102 and #11358.
This PR does the following:
- It deprecates
--install-options
. - It refactors
check_install_build_global
intocheck_legacy_setup_py_options
that is called after parsing the requirements from CLI options and req files. This allows us to reason about these options in the context of the command for which they are used, and also avoids a side effect (disallow_binaries
) in the req file parser - It clarifies the WARNING message
Disabling all use of wheels due to the use of --build-option / --global-option / --install-option.
intoImplying --no-binary=:all: due to the presence of --build-option / --global-option / --install-option. Consider using --config-settings for more flexibility.
. This is clearer and will help understanding when we disentangle--no-binary
. Fixes #8406.
TODO
- [x] tests
Added a couple of tests and rebased. This is ready to review and merge.
I've rebased this to check how it combines with the other related deprecations.
Using --install-option
triggers all of them which is a little bit noisy. The messages are coherent in my view, but I may be biased due to having spent way too much time on this. So I very much welcome feedback by other testers. cc/ @pypa/pip-committers