packaging icon indicating copy to clipboard operation
packaging copied to clipboard

Add compatibility for Pyodide-tagged wheels

Open hoodmane opened this issue 1 year ago • 6 comments

We are changing our wheel platform tag to pyodide_2024_0 so we need to teach packaging to map Emscripten platform to this.

cc @henryiii

hoodmane avatar May 21 '24 11:05 hoodmane

@mayeut @henryiii @pradyunsg would appreciate review on this from any of you (and running the workflow).

hoodmane avatar Jun 07 '24 02:06 hoodmane

Tests and coverage check now pass locally for me.

hoodmane avatar Jun 17 '24 23:06 hoodmane

I stumbled into this PR, somehow – I guess the tests are valid for only Python 3.12 and should be skipped for other Python versions, @hoodmane?

agriyakhetarpal avatar Aug 03 '24 12:08 agriyakhetarpal

Now, we also pre-emptively need 2025_0 as we broke/will be breaking the ABI.

agriyakhetarpal avatar Jan 24 '25 06:01 agriyakhetarpal

+1 - it would be great if packaging installed from PyPi would just work out of the box in Pyodide

juntyr avatar Feb 19 '25 17:02 juntyr

I guess the only remaining parts here are to generalise the ABI tags, so that emscripten_x_y_zw and pyodide_abcd_e, where $$x, y, z, w, a, b, c, d, e ∈ [0, 9] $$ work, and skip the tests on unsupported Python versions (by probably grabbing the Python version from pyodide config get python_version)?

agriyakhetarpal avatar Feb 22 '25 10:02 agriyakhetarpal

What are the next steps for this?

ofek avatar Oct 28 '25 20:10 ofek

This can only be merged once PEP 783 is approved.

hoodmane avatar Oct 28 '25 22:10 hoodmane

Indeed, and what's the status of that? I haven't seen any discussion update in months so I don't quite understand the state of the proposal.

ofek avatar Oct 28 '25 22:10 ofek

Well I assume you also asked on the discuss thread? You can see the new comments there. https://discuss.python.org/t/pep-783-emscripten-packaging/86862/64

hoodmane avatar Oct 28 '25 23:10 hoodmane

Ah I don't have notifications for that enabled apparently, thanks a lot!

ofek avatar Oct 28 '25 23:10 ofek