packaging icon indicating copy to clipboard operation
packaging copied to clipboard

Adopt pre-commit.ci?

Open pradyunsg opened this issue 3 years ago • 4 comments

It's generally a much better experience around pre-commit and we'll get automated PRs for updates.

Thoughts?

pradyunsg avatar Apr 06 '21 08:04 pradyunsg

No opinion to speak of. Is it free for us?

brettcannon avatar Apr 06 '21 19:04 brettcannon

https://pre-commit.ci/

Information is pretty sparse, looks like it’s still trying to get off the ground and more like a new toy right now. I’m more than willing to bet on Anthony to succeed though, the most worrying part is actually if our workload would be too heavy for the service to handle at the current stage.

uranusjr avatar Apr 07 '21 13:04 uranusjr

👋 the service is pretty stable at the moment and has automated monitoring for usual failure scenarios (~3 pages in the last 2 weeks for 3 "lost" runs, one was a bug which was fixed and then rerun, another was a banned user trying to mine crypto, and the other was a repository which was deleted due to DMCA). it's being used by ~220 organizations and has performed ~45,000 runs so far so it's fairly battle tested. I don't think pypa's usage would be significantly more than some of the others that are utilizing the service (pytest for example)

it will be free for public repositories indefinitely, I'm currently working with github to get paid, private repository support up and running.

asottile avatar Apr 15 '21 19:04 asottile

I've been using it heavily since beta/alpha (quite some time now, of the order months) and I love it, would highly recommend. Scikit-HEP has adopted it for 14 of our main projects, cibuildwheel uses it, and the iris-hep.org website repo uses it.

Looks like virtualenv and setuptools_scm already use it in the PyPA.

henryiii avatar Apr 20 '21 21:04 henryiii