distutils icon indicating copy to clipboard operation
distutils copied to clipboard

In the command 'bdist_dumb' the short option '-d' is used twice

Open sinoroc opened this issue 5 years ago • 3 comments

Issue was originally filed for CPython here:

  • https://bugs.python.org/issue38145

In the 'distutils' command 'bdist_dumb', the short option 'd' is used for both the 'bdist-dir' and 'dist-dir' options.

The bdist-dir option appeared first on 2000-05-13 in commit: ba0506b

The dist-dir option appeared then on 2000-07-05 in commit: c4eb84a

There appears to have been no version released between these two commits, so most likely the global behaviour of the command has stayed consistent.

The short option d actually triggers the dist-dir option, not the bdist-dir option.

It is therefore safe to change the short option for bdist-dir. A choice consistent with other similar distutils commands is 'b'.

And the originally suggested fix is here:

  • https://github.com/python/cpython/pull/16086

Is it something that is still worth fixing?

sinoroc avatar Oct 20 '20 14:10 sinoroc

Definitely seems worth fixing. It also sounds like it's not urgent. Let's defer this effort until this codebase has some permanent traction in the ecosystem.

jaraco avatar Dec 24 '20 19:12 jaraco

Happy to resume work on this. Care to draft a fix?

jaraco avatar Oct 04 '22 17:10 jaraco

It’s a small change, but a breaking one: https://github.com/python/cpython/pull/16086/files (not that small if you have unit tests for the command now)

On the other hand, I don’t know who would use bdist_dumb and not wheels.

merwok avatar Oct 04 '22 17:10 merwok