cibuildwheel icon indicating copy to clipboard operation
cibuildwheel copied to clipboard

fix(action): no need to modify path for extras

Open henryiii opened this issue 1 month ago • 1 comments

Try simpler action. See #2663.

henryiii avatar Nov 24 '25 16:11 henryiii

I'm not sure why this had an impact as you mentioned in https://github.com/pypa/cibuildwheel/issues/2663#issuecomment-3571618005, maybe we should add a backend test (meson-python, scikit-build-core, maturin) ?

uv is still used directly in the virtualenv function and pip on Windows https://github.com/pypa/cibuildwheel/blob/3c2d5961de159ac990d4225e499c4f554ee3e0e8/cibuildwheel/venv.py#L111 https://github.com/pypa/cibuildwheel/blob/3c2d5961de159ac990d4225e499c4f554ee3e0e8/cibuildwheel/platforms/windows.py#L578

mayeut avatar Dec 07 '25 08:12 mayeut

Should we fix the direct usage, then?

henryiii avatar Dec 11 '25 19:12 henryiii

Thanks for this henryiii! I think both are a good idea - removing the direct uv usage and adding a test for an alternate backend.

Do we understand why the action change causes an issue with link.exe in meson-python? I don't see how that relates... regardless this solution seems good to me.

joerick avatar Dec 13 '25 18:12 joerick