cibuildwheel icon indicating copy to clipboard operation
cibuildwheel copied to clipboard

fix: support --no-isolation with build[uv]

Open henryiii opened this issue 1 year ago • 3 comments

Fixing #1887. I didn't special case chained short flags, like -xn or -nx, maybe we should?

henryiii avatar Jun 17 '24 21:06 henryiii

It looks to me like you're just disabling uv support when --no-isolation is passed. Is this a misconfiguration then? As in "you can't specify build[uv] and --no-isolation, if you need --no-isolation you must use build"?

joerick avatar Jun 20 '24 14:06 joerick

We still install everything via uv when build[uv] is set. It means “use build and uv”. The problem is that with no isolation, build itself isn’t using uv because it doesn’t install anything or make and environment. That’s why it errors on that flag.

henryiii avatar Jun 20 '24 14:06 henryiii

Ah, got it. Understood!

joerick avatar Jun 22 '24 13:06 joerick

If I add a utility for this, it will clash with #1873, so let's do this as a quick fix, and then write a utility later that tries to be smarter for combined flags.

henryiii avatar Jul 01 '24 03:07 henryiii

I think we could release after this. Would like to get b3 out!

henryiii avatar Jul 01 '24 03:07 henryiii

I didn't special case chained short flags, like -xn or -nx, maybe we should?

I don't think it's necessary but a note / caution shall be added in the docs then.

mayeut avatar Jul 01 '24 05:07 mayeut

I think we could release after this. Would like to get b3 out!

I cancelled Travis CI to get some time for manylinux. CentOS 7 reached End-Of-Life so mirrors shall be updated on manylinux2014. IMHO, we should wait for the new images before the release.

mayeut avatar Jul 01 '24 18:07 mayeut