cibuildwheel icon indicating copy to clipboard operation
cibuildwheel copied to clipboard

@v2 doesn't exist

Open elalish opened this issue 1 year ago • 3 comments

Description

With every other action I've used, you can specify e.g. pypa/cibuildwheel@v2 to automatically get the latest 2.x.x version that's published. However, this technique fails with this package, requiring something like pypa/[email protected], which just bit us because it failed, needing the update in v2.16.5, which would have been nice to get automatically.

Is this intentional?

Build log

No response

CI config

No response

elalish avatar Mar 04 '24 22:03 elalish

You can use v2.16, we provide that. We add and remove wheels in minor releases so it’s not safe to pin to v2.

henryiii avatar Mar 04 '24 23:03 henryiii

Okay, thanks. I don't fully understand, but might be nice to call out in the docs since it's different than all the other github actions versioning.

elalish avatar Mar 05 '24 00:03 elalish

The official actions have a private action they use to create the "v2" style versions. Some other actions try to follow this, some use different names (https://github.com/pypa/gh-action-pypi-publish uses release/v1, for example), and some do not provide these at all (https://github.com/pre-commit/action, for example).

Pointing this out more clearly (and maybe using it in more places) does sound like a good idea.

The recent issue with GHA upgrading powershell to a version that broke us serves as a reminder that GHA does not provide a "stable" platform that will work even will full pinning. I think that's good (way better than stable but forever frozen and buggy platforms), but it does mean that pinning to a patch version isn't always that helpful.

henryiii avatar Mar 05 '24 02:03 henryiii