cibuildwheel icon indicating copy to clipboard operation
cibuildwheel copied to clipboard

[docs][infra] Set up a pypa.io subdomain?

Open webknjaz opened this issue 2 years ago • 10 comments

Description

$sbj. It's essentially the same as https://github.com/pypa/pipx/issues/1058. Any objections?

Build log

No response

CI config

No response

webknjaz avatar Dec 06 '23 13:12 webknjaz

This would be nice. But, is there a way to make all the links to cibuildwheel.readthedocs.io redirect to the new domain? There are a lot of links to that domain. I'm not sure I'd like to make the change unless we can be confident that URLs will properly redirect. e.g. if a link sent a user to https://cibuildwheel.readthedocs.io/en/stable/options/#before-build, they end up at https://cibuildwheel.pypa.io/en/stable/options/#before-build

joerick avatar Jan 26 '24 20:01 joerick

Yes, that's how it works out of the box, zero config needed.

webknjaz avatar Jan 26 '24 22:01 webknjaz

@ewdurbin hey Ee, could you make another CNAME for this RTD project too, plz?

webknjaz avatar Jan 26 '24 22:01 webknjaz

You can see this working for build, which did this recently.

henryiii avatar Jan 26 '24 23:01 henryiii

Nice, yeah I just tested it and the redirect was perfect, even including the URL fragment (i guess this is standard browser behaviour, TIL).

https://pypa-build.readthedocs.io/en/stable/installation.html#compatibility

joerick avatar Jan 27 '24 11:01 joerick

@ewdurbin hey Ee, could you make another CNAME for this RTD project too, plz?

Yes. Please add my user on readthedocs.org for the project first. (This is primarily so that DNS/cert/etc settings can be managed in the future by PSF infra).

ewdurbin avatar Jan 29 '24 11:01 ewdurbin

@joerick is the only one listed on rtd, so he’ll need to do it.

henryiii avatar Jan 29 '24 13:01 henryiii

Did we not do that with build?

henryiii avatar Jan 29 '24 13:01 henryiii

Thanks @ewdurbin ! just sent you the invite to the RtD project.

edit: also invited @henryiii for bus-factor purposes

joerick avatar Jan 29 '24 15:01 joerick

CNAME and domain configuration added.

ewdurbin avatar Jan 29 '24 15:01 ewdurbin

@henryiii @joerick RTD config update pending?

webknjaz avatar Feb 26 '24 20:02 webknjaz

I totally forgot about this, thanks for the reminder! I'll take a look tomorrow. It will probably need some code/docs edits too so might require some planning to sync it up with a release.

joerick avatar Feb 26 '24 21:02 joerick

It will probably need some code/docs edits

Not really. Those shouldn't be blockers since the redirects will work for the old links just fine.

webknjaz avatar Feb 27 '24 03:02 webknjaz

Those shouldn't be blockers since the redirects will work for the old links just fine.

Sure, not blockers but I don't see any reason to rush, I'd rather keep things neat and make the change all at once with a release.

joerick avatar Mar 04 '24 10:03 joerick

It's done! Btw, thanks to whoever changed over the sidebar URL :)

joerick avatar Mar 11 '24 21:03 joerick