cibuildwheel icon indicating copy to clipboard operation
cibuildwheel copied to clipboard

Check CI coverage for Python versions

Open joerick opened this issue 2 years ago • 2 comments

Let's figure out why we didn't catch #1478 in CI. Creating an issue to ensure we don't forget!

joerick avatar Apr 19 '23 07:04 joerick

I looks like Travis scripts only worry about the last command for the error code. https://github.com/travis-ci/travis-ci/issues/1066 .

https://github.com/pypa/cibuildwheel/blob/5e15bb25b428e1bf2daf2215f173d2b40135f56f/.travis.yml#L55-L62

A set -o errexit should do the trick. I wonder if that will work on Windows too, do they run a POSIX shell on all platforms?

joerick avatar Apr 19 '23 08:04 joerick

this is still an issue on TravisCI as the tests are failing but the workflow isn't...

mayeut avatar Jun 30 '24 18:06 mayeut