pypa
Disable `colorama` on Linux
Got another problem. colored messages are piling at the end of the output.
Need to add more commits to turn off output buffering.
The problems with the output are likely https://github.com/pypa/cibuildwheel/issues/1161?
@henryiii without output buffering everything works as expected. But I need to properly test formatting.
I’ll see if I can easily add a test for missing colorama when I’m at a computer.
edit: code looks simpler now, I think one PR for the two fixes is likely fine.
@gaborbernat or anyone else, is there an easy way to run an "uninstall colorama" only on windows in tox? Would keep from having to list the test deps again, which is what I'm trying here to see if that fixes the coverage check.
Personally I would rather print with flush and format were separate functions but I don't think it matters that much.
Is there anything else that needs to be done to push this? I'd like to propose some semantic changes to the build output, and the diff will conflict with this one.
We don’t need to make the coverage pass. I’m traveling till the 27th so can only try a little bit here and there. Currently it seems like the coverage info from the path job is not being reported properly.
@gaborbernat I'd like your sign-off on this, especially since I touched the tox config quite a bit. We now produce coverage info from all the runs, and use the coverage job to combine it (it was unused before).