When repairing a pure python wheel, exit code should be 0
Based on https://github.com/pypa/auditwheel/issues/47, when doing auditwheel repair on a pure python wheel, the exit code should not be 1.
My use case is that I'm running repair on all the wheel produced by some colleague, and if they're pure python, it makes the CI pipeline to fail.
Codecov Report
Patch coverage: 100.00% and no project coverage change.
Comparison is base (
90d382e) 92.33% compared to head (c57b1df) 92.33%.
Additional details and impacted files
@@ Coverage Diff @@
## main #438 +/- ##
=======================================
Coverage 92.33% 92.33%
=======================================
Files 23 23
Lines 1291 1291
Branches 302 302
=======================================
Hits 1192 1192
Misses 57 57
Partials 42 42
| Files Changed | Coverage Δ | |
|---|---|---|
| src/auditwheel/main_addtag.py | 89.74% <100.00%> (ø) |
|
| src/auditwheel/main_repair.py | 90.90% <100.00%> (ø) |
|
| src/auditwheel/main_show.py | 83.05% <100.00%> (ø) |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'd still want to fail on this one. How about a specific error code for this case ?
cc @lkollar for another opinion
I'd still want to fail on this one. How about a specific error code for this case ?
cc @lkollar for another opinion
That will require special handling in the CI for my use case anyway. Why a noop should exit as a failure? I'd expect for it to not error if there's nothing to do...