auditwheel
auditwheel copied to clipboard
feature: allow specifying additional library paths (fixes: #373)
Add new --add-path option to auditwheel repair to search for libraries in additional directories. This avoid having to manipulate LD_LIBRARY_PATH in the calling process (e.g. cibuildwheel), as this can have undesirable side-effects.
The name of the option is chosen to match the one provided by
delvewheel
on Windows.
fixes #373
NOTE: this option would actually also make sense for the lddtree
and show
commands but I was unsure how to add it to multiple commands without duplicating code.
Codecov Report
Merging #374 (ae0aae5) into main (bc524d6) will decrease coverage by
0.35%
. The diff coverage is28.57%
.
@@ Coverage Diff @@
## main #374 +/- ##
==========================================
- Coverage 92.36% 92.01% -0.36%
==========================================
Files 23 23
Lines 1258 1265 +7
Branches 307 309 +2
==========================================
+ Hits 1162 1164 +2
- Misses 55 59 +4
- Partials 41 42 +1
Impacted Files | Coverage Δ | |
---|---|---|
src/auditwheel/main_repair.py | 84.28% <28.57%> (-6.20%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f3c7691...ae0aae5. Read the comment docs.
@mayeut note that all of the tests in tests/integration/test_manylinux.py
which currently manipulate LD_LIBRARY_PATH could be rewritten to use this new option. Would you like me to do this?
What the progress on this? I have ran into this issue repairing wheels that were built linking to libraries installed bia conda.
Would this PR resolve limitation #1? For instance, I'd like to create a package using pure ctypes
.