auditwheel icon indicating copy to clipboard operation
auditwheel copied to clipboard

Exit code of auditwheel show

Open kszucs opened this issue 6 years ago • 5 comments

Is there a command which validates the wheel and exits with 1 if any problems are occured? I guess the closest one is auditwheel show but it always exists with 0, so it is hard to get notified about non compliant wheels.

kszucs avatar Jul 09 '19 17:07 kszucs

I think we should do this, perhaps under a new validate or similar subcommand. This could help automated validations, like what we plan to do for PyPI uploads.

validate could do the following:

  • If no platform tag is supplied, attempt to parse it from the file name and validate against that. Return error if non-compliant.
  • If no manylinux tag is present exit with an error value.
  • If a platform tag is specified, validate against that and if non-compliant, return an error value.

lkollar avatar Aug 07 '19 20:08 lkollar

I'm +1 for a new validate command as proposed by @lkollar. However, I have one comment on what's proposed:

If no platform tag is supplied, attempt to parse it from the file name and validate against that. Return error if non-compliant.

validate shall not take any arguments except for the wheel filename that needs to be checked. The platform tag shall be inferred from the wheel filename & cross-checked with Tag in dist-info/WHEEL

It would be nice to be able to do cross-platform validation (must have for PyPI if they ever go with that sort of validation)

mayeut avatar Apr 03 '21 12:04 mayeut

It would be nice to be able to do cross-platform validation (must have for PyPI if they ever go with that sort of validation)

delocate provides similar functionality for macOS, perhaps it would worth collaborating with @matthew-brett for better multi-platform support.

kszucs avatar Apr 03 '21 17:04 kszucs

delocate provides similar functionality for macOS, perhaps it would worth collaborating with @matthew-brett for better multi-platform support.

I meant x86_64 vs aarch64 rather than linux vs macOS which is another issue entirely.

mayeut avatar Apr 03 '21 17:04 mayeut

Actually, auditwheel started as a partial fork of delocate - but getting them closer together again is a good goal...

matthew-brett avatar Apr 03 '21 17:04 matthew-brett