Paul Tan
Paul Tan
> Having said that, should we do this at AB-3? Depending on how greatly the UG is revamped, the danger of this is that if there are any changes to...
@damithc > > For screenshots of the GUI, do ensure that the steps to reproduce them are documented. Most importantly: the window dimensions for taking the screenshot. No MacOS please,...
Sure, PR welcome.
imo, while this is an issue, I'm not sure it is actually a big problem in practice. What's wrong with just adding a new commit?
@damithc > Yes, not a big problem. So, this can be `p.Low`? > In this case students might end up adding dummy commits (to the master branch!) just to confirm...
Style A https://github.com/se-edu/addressbook-level4/blob/c9b222cb2870b23760122cadb82248769442fa96/src/main/java/seedu/address/commons/core/GuiSettings.java#L43-L58
Style B https://github.com/se-edu/addressbook-level4/blob/c9b222cb2870b23760122cadb82248769442fa96/src/main/java/seedu/address/model/AddressBook.java#L107-L112
@Zhiyuan-Amos @yamgent @yamidark Okay, it's quite obvious by now that Style A is the winner, but there are a few details to iron out. Here's my proposal: ```java public boolean...
@0WN463 Thanks, you raised a lot of real issues. :-) > Inb4 Java 10 no longer available publicly. :stuck_out_tongue: Unfortunately moving AB-4 into a JDK-11+ future will require quite a...
@tenvinc > There might be unhandled exceptions in AB4 which might cause the app to crash. In particular, for each field defined, there is a corresponding checkArgument function to double...