Paul Tan

Results 28 comments of Paul Tan

@fzdy1914 > This issue can be closed, as `isFileExists` is now edited to be: > > ``` > public static boolean isFileExists(Path file) { > return Files.exists(file) && Files.isRegularFile(file); >...

@Zhiyuan-Amos @yamgent Would it be possible to reboot this conversation and decide: (1) If this is really a big enough issue, and if so (2) what the replacement name will...

> Furthermore, the UI doesn't need to know what kind of list to bind itself too, as long as it is an ObservableList. The UI *does* need to know which...

> I think that is good. Well, some might complain that "displayed person list" is too biased towards visual user input interfaces. But really, it's just an abstract term. What's...

Alright, here is my re-take after a few months: To start of: I agree that "filteredPersonsList" is not a very good name, but for a different reason: if students add...

@eugenepeh > The method getTagSet should not be in SampleDataUtil since it does not provide any sample data and also what it is doing is similar to the method ParserUtil.parseTags(Collection...

@eugenepeh > hmm that's true but the above implement in Person Builder looks weird because we're calling getTagSet in SampleDataUtil yet it doesn't provides SampleData. Oh, didn't notice that `getTagSet`...

@damithc Where do you think `SampleDataUtil` should be moved to? `logic`, `ui`, `MainApp`?

> The number of visual aids should also be increased to enhance readability. As it is, the whole UG only has one image in the header and users might have...

For screenshots of the GUI, do ensure that the steps to reproduce them are documented. Most importantly: the window dimensions for taking the screenshot. No MacOS please, no developer would...