Johannes Tax
Johannes Tax
This requires updating our CI [Dockerfile](https://github.com/open-telemetry/opentelemetry-cpp/blob/master/ci/Dockerfile) with a compiler supporting C++20. the `ubuntu:20.04` image provides gcc version supporting C++20, however there's no gcc-4.8 package for this Ubuntu version. What I...
Make sure to install [g++-10](https://packages.ubuntu.com/focal/g++-10), which provides latest support for C++20 and supports the `-std=c++20` flag.
This should be doable. I'm not sure if we can preserve the ability to automatically end a span when it is deallocated (or goes out of scope). We might end...
One possible approach for this, which can be implemented very easily: Return `api::Span` as a `unique_ptr` when a span is started, only convert it into a `shared_ptr` if it is...
> SpanProcessor interface accepts Recordable. Following the interface, should TraceZSpanProcessor accept Recordable as well? If yes, can we add getter functions to the Recordable interface? No, we don't want to...
I think you have two problems here that you should reason about in separation: 1. The thread-safety of `SpanData` itself. The recordable implementation `SpanData` doesn't give thread safety guarantees in...
This is something we have been actively discussing in the messaging workgroup (meeting weekly Thursdays 8am PST). In the [OTEP we are currently working on](https://github.com/open-telemetry/oteps/pull/192) we explicitly state [basic requirements...
This is partly covered by #2750, which lays out general requirements for context propagation in messaging scenarios. As mentioned in a comment above, this doesn't go into details of how...
> How about filtering for requests that exceed a certain size? Or requests without body (length=0)? Also, having those attributes on spans will provide more help in troubleshooting or reproducing...
@Oberon00 Not sure if I interpret [the RPC conventions](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/rpc.md#distinction-from-http-spans) correctly, but it seems to always recommend the creation of the HTTP span, either as child of an RPC span or...