micropip icon indicating copy to clipboard operation
micropip copied to clipboard

Verbose setting overwrite custom logger level.

Open Carreau opened this issue 1 year ago • 2 comments

Transcations also have a verbose attribute which is unused.

def install(..., verbose=<value default False>) overwrite a custom logger level. This and a few other places should allow None meaning "don't change the level".

Carreau avatar Jul 21 '24 10:07 Carreau

(in my case it is overwritting to a lower level as I start my session with a getLogger('micropip').setLevel(DEBUG).

Carreau avatar Jul 21 '24 10:07 Carreau

Thanks, that sounds reasonable to me.

I wonder if it would be better to remove the verbose parameter at all, and let users externally set getLogger('micropip').setLevel() to chang the log level. I introduced the verbose parameter to help users see what micropip does internally, but probably it is a bad practice logging-wise.

ryanking13 avatar Jul 23 '24 10:07 ryanking13

Should have been fixed by #132

Carreau avatar Sep 19 '24 08:09 Carreau