micropip icon indicating copy to clipboard operation
micropip copied to clipboard

DOC: install index url missing from high level doc and incorrect docstring:

Open Carreau opened this issue 1 year ago • 2 comments

https://github.com/pyodide/micropip/blob/e107d892e3d3d969bdaf6ef2d2063ab47f81e19c/micropip/_commands/install.py#L96-L98

state that index "should support json api", as far as I can tell this is not true as we can see that Transation will use query_package:

https://github.com/pyodide/micropip/blob/e107d892e3d3d969bdaf6ef2d2063ab47f81e19c/micropip/package_index.py#L262-L284

https://github.com/pyodide/micropip/blob/e107d892e3d3d969bdaf6ef2d2063ab47f81e19c/micropip/package_index.py#L80-L88

which does support simple API.

(I have not tried though).

I think mentioning index could also be added in the pyodide documentation itslef in adiition to direct URLS:

https://github.com/pyodide/pyodide/blob/9f49030ef511296574885720282887bea6c6fd54/docs/usage/loading-packages.md#installing-wheels-from-arbitrary-urls

Carreau avatar Jun 28 '24 09:06 Carreau

Thanks. You are right. micropip now support Simple APIs (both HTML and JSON). Could you open a PR?

ryanking13 avatar Jun 28 '24 09:06 ryanking13

Yes, I can send a pr a bit later. I'll try to do both one here, and on Pyodide to document it.

Carreau avatar Jun 28 '24 09:06 Carreau