tangos icon indicating copy to clipboard operation
tangos copied to clipboard

rockstar+RAMSES functionality

Open AnatoleStorck opened this issue 2 years ago • 5 comments

Added functionality for adding RAMSES datasets with rockstar-galaxies catalogues using yt to tangos.

AnatoleStorck avatar Nov 02 '23 11:11 AnatoleStorck

Thanks @AnatoleStorck @cphyc - do you understand why the enzo test database now fails to build?

If needed you can try this locally by running export INTEGRATION_TESTING=1; ./build.sh in the test_tutorial_build folder

apontzen avatar Nov 02 '23 12:11 apontzen

I have moved the new functions in the general YT handler which were causing the Enzo test to fail (I still do not understand why) into the input handler for RAMSES+rockstar. The Enzo test now passes. Since this pull request is for supporting RAMSES+rockstar functionality, this should be fine.

AnatoleStorck avatar Nov 10 '23 11:11 AnatoleStorck

To me it looks like people who have developed their own input handlers that derive from YtInputHandler will be tripped up by this. Unfortunately I think it's necessary to solve the underlying problem rather than remove functionality from the crucial base class.

(I am not sure why the tests are not actually running on Github Actions, by the way - will see if I can figure that out)

apontzen avatar Nov 10 '23 12:11 apontzen

@cphyc and I fixed the issue, occurring due to the handler not importing the statfile if it exists.

AnatoleStorck avatar Nov 10 '23 16:11 AnatoleStorck

If you can pull master into this branch, it will also run the unit tests. At the moment only the integration test is running due to a configuration error in github actions.

apontzen avatar Nov 11 '23 22:11 apontzen