pymor icon indicating copy to clipboard operation
pymor copied to clipboard

Successive constraints method

Open HenKlei opened this issue 1 year ago • 8 comments

Since @sdrave was complaining about the missing successive constraints method for a few times now, I started implementing something in that direction. However, this is far from being finished at the moment.

HenKlei avatar Mar 16 '23 17:03 HenKlei

Seems like I should complain more often ... Maybe we can discuss things offline next week?

sdrave avatar Mar 22 '23 09:03 sdrave

Seems like I should complain more often ... Maybe we can discuss things offline next week?

Yes of course, let's discuss this next week.

HenKlei avatar Mar 23 '23 09:03 HenKlei

@sdrave Do you think you will have time to discuss and look into this before the release?

HenKlei avatar Oct 19 '23 12:10 HenKlei

~~Note to myself: Use pyMOR's eigs-method instead of numpy.~~ Done.

HenKlei avatar Feb 13 '24 13:02 HenKlei

It would be great if you could take a look at this @sdrave when you find time.

HenKlei avatar Apr 27 '24 14:04 HenKlei

The pipelines are failing due to a very old scipy version (1.5.4) where the 'highs' method (which is now the default) was not available as solver of a linear program in scipy. 'simplex' would be a method that is supported in probably all versions but is considered legacy in current versions. So maybe also not the best option to use that one as default.

How about pinning scipy to >=1.7.0?

HenKlei avatar Apr 27 '24 14:04 HenKlei

The pipelines are failing due to a very old scipy version (1.5.4) where the 'highs' method (which is now the default) was not available as solver of a linear program in scipy. 'simplex' would be a method that is supported in probably all versions but is considered legacy in current versions. So maybe also not the best option to use that one as default.

How about pinning scipy to >=1.7.0?

Debian oldstable has 1.6.0. I think that should be enough as well? Any reasons to require 1.7?

sdrave avatar May 06 '24 16:05 sdrave

The pipelines are failing due to a very old scipy version (1.5.4) where the 'highs' method (which is now the default) was not available as solver of a linear program in scipy. 'simplex' would be a method that is supported in probably all versions but is considered legacy in current versions. So maybe also not the best option to use that one as default. How about pinning scipy to >=1.7.0?

Debian oldstable has 1.6.0. I think that should be enough as well? Any reasons to require 1.7?

You're right, 1.6.0 would be sufficient.

HenKlei avatar May 07 '24 13:05 HenKlei

Is the scm module in algorithms what you anticipated @sdrave? I will look into your further remarks in the next days.

HenKlei avatar Jun 04 '24 14:06 HenKlei

I am not entirely sure what kind of example for the estimation of the coercivity constant you have in mind @sdrave and what kinds of plots/results you would like to see. Maybe you can have a short look if the updated demo goes into the right direction.

HenKlei avatar Jun 14 '24 07:06 HenKlei

This pull request modifies pyproject.toml or requirements-ci-oldest-pins.in. In case dependencies were changed, make sure to call

make ci_requirements

and commit the changed files to ensure that CI runs with the updated dependencies.

github-actions[bot] avatar Jun 20 '24 13:06 github-actions[bot]

This pull request modifies pyproject.toml or requirements-ci-oldest-pins.in. In case dependencies were changed, make sure to call

make ci_requirements

and commit the changed files to ensure that CI runs with the updated dependencies.

github-actions[bot] avatar Jun 20 '24 16:06 github-actions[bot]

CI is passing now @sdrave ;-)

HenKlei avatar Jun 21 '24 08:06 HenKlei

This pull request modifies pyproject.toml or requirements-ci-oldest-pins.in. In case dependencies were changed, make sure to call

make ci_requirements

and commit the changed files to ensure that CI runs with the updated dependencies.

github-actions[bot] avatar Jun 21 '24 12:06 github-actions[bot]

This pull request modifies pyproject.toml or requirements-ci-oldest-pins.in. In case dependencies were changed, make sure to call

make ci_requirements

and commit the changed files to ensure that CI runs with the updated dependencies.

github-actions[bot] avatar Jun 21 '24 12:06 github-actions[bot]

Thanks @sdrave, this will be merged then.

HenKlei avatar Jun 21 '24 12:06 HenKlei

@HenKlei, could you also update the first PR comment and make it a bit more informative?

sdrave avatar Jun 21 '24 12:06 sdrave

Seems like you have to give green lights @sdrave :-D

HenKlei avatar Jun 21 '24 13:06 HenKlei