pymor icon indicating copy to clipboard operation
pymor copied to clipboard

StationaryModel with multiple right-hand sides

Open pmli opened this issue 2 years ago • 4 comments

See https://github.com/pymor/pymor/discussions/1608

pmli avatar Oct 31 '22 17:10 pmli

Codecov Report

Merging #1788 (7898cca) into main (7d9f5f6) will increase coverage by 0.14%. The diff coverage is 100.00%.

Additional details and impacted files
Flag Coverage Δ
github_actions 75.14% <100.00%> (?)
gitlab_ci 86.52% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pymor/models/basic.py 88.52% <100.00%> (+0.49%) :arrow_up:
src/pymortests/models/model.py 98.92% <100.00%> (+0.08%) :arrow_up:
src/pymortests/fixtures/operator.py 98.51% <0.00%> (+0.59%) :arrow_up:
.../pymor/discretizers/builtin/gui/matplotlib_base.py 57.48% <0.00%> (+0.78%) :arrow_up:
src/pymortests/strategies.py 88.78% <0.00%> (+1.24%) :arrow_up:
src/pymortests/vectorarray.py 91.62% <0.00%> (+1.29%) :arrow_up:
src/pymortests/algorithms/basic.py 98.58% <0.00%> (+1.41%) :arrow_up:
src/pymordemos/thermalblock_gui.py 79.50% <0.00%> (+1.63%) :arrow_up:
src/pymortests/demos.py 92.48% <0.00%> (+2.31%) :arrow_up:
src/pymor/core/defaults.py 79.71% <0.00%> (+2.41%) :arrow_up:
... and 4 more

codecov[bot] avatar Nov 01 '22 12:11 codecov[bot]

Indeed. It would also be nice for discretizers to know how to define multiple right-hand sides, such that it would be easy to define Models for testing.

pmli avatar Nov 02 '22 19:11 pmli

@pmli, if this isn't needed urgently, I would propose to wait until we have decided how StationaryModel will look like in the future. Then I would adjust the RB code to also support multiple RHSs.

sdrave avatar Nov 23 '22 14:11 sdrave

Sounds good to me.

pmli avatar Nov 28 '22 13:11 pmli