pymor icon indicating copy to clipboard operation
pymor copied to clipboard

yml module loader

Open MagnusOstertag opened this issue 3 years ago • 6 comments

Just to get some general feedback. Resolves #853

MagnusOstertag avatar Feb 10 '22 02:02 MagnusOstertag

Maybe the spec doc could also show the alternative array notation for those not familiar with YAML?

renefritze avatar Feb 10 '22 08:02 renefritze

Does it make sense to use JSON instead of YAML? At least there is a JSON parser in the standard library...

pmli avatar Feb 10 '22 13:02 pmli

Does it make sense to use JSON instead of YAML? At least there is a JSON parser in the standard library...

IMO plain JSON is harder for humans to write or read. I'd consider TOML a somewhat practical alternative, but would still prefer YAML.

renefritze avatar Feb 10 '22 13:02 renefritze

Does it make sense to use JSON instead of YAML? At least there is a JSON parser in the standard library...

IMO plain JSON is harder for humans to write or read. I'd consider TOML a somewhat practical alternative, but would still prefer YAML.

Ok, then this might be a good reason for me to learn YAML. Regarding TOML, there is at least a PEP proposing to add a TOML parser to the standard library. There is configparser in the standard library, but I don't know how useful it is for this case.

pmli avatar Feb 10 '22 17:02 pmli

Does it make sense to use JSON instead of YAML? At least there is a JSON parser in the standard library...

IMO plain JSON is harder for humans to write or read. I'd consider TOML a somewhat practical alternative, but would still prefer YAML.

Ok, then this might be a good reason for me to learn YAML. Regarding TOML, there is at least a PEP proposing to add a TOML parser to the standard library. There is configparser in the standard library, but I don't know how useful it is for this case.

Nobody uses TOML, at least compared to YAML.

sdrave avatar Feb 11 '22 11:02 sdrave

Codecov Report

Merging #1565 (ba62f66) into main (d69e1be) will decrease coverage by 10.96%. The diff coverage is 16.66%.

Impacted Files Coverage Δ
src/pymor/models/loader.py 16.66% <16.66%> (ø)
src/pymordemos/fenics_nonlinear.py 0.00% <0.00%> (-97.30%) :arrow_down:
src/pymordemos/neural_networks_instationary.py 0.00% <0.00%> (-97.02%) :arrow_down:
src/pymordemos/neural_networks.py 0.00% <0.00%> (-96.43%) :arrow_down:
src/pymor/reductors/neural_network.py 1.01% <0.00%> (-93.27%) :arrow_down:
src/pymordemos/neural_networks_fenics.py 0.00% <0.00%> (-92.96%) :arrow_down:
src/pymor/models/neural_network.py 4.28% <0.00%> (-91.43%) :arrow_down:
src/pymor/tools/io/vtk.py 3.44% <0.00%> (-91.38%) :arrow_down:
src/pymor/bindings/fenics.py 0.46% <0.00%> (-83.73%) :arrow_down:
src/pymortests/mpi_run_demo_tests.py 2.12% <0.00%> (-78.73%) :arrow_down:
... and 68 more

codecov[bot] avatar Feb 16 '22 10:02 codecov[bot]

Closing due to inactivity.

sdrave avatar Nov 28 '22 13:11 sdrave