pymodbus Use mock.patch.object to avoid protected access errors.

Jul 21 '24 23:07 jameshilliard

Having 2 PR solving the same problem in the same file is over the top, and wasting my time, since I have to review them.

Um, it's a different file right? Path for this PR looks to be test/framers/test_tbc_transaction.py while #2251 is for test/test_transaction.py. So test/framers/test_tbc_transaction.py is rather similar to test/test_transaction.py, are we supposed to have both of these tests or just one?

Jul 22 '24 08:07 jameshilliard

If you had a look at the files you would see it’s the same file, just copied to prepare for major changes.

tbc == to be changed

Jul 22 '24 08:07 janiversen

If you had a look at the files you would see it’s the same file,

Yeah...I missed that somehow, had assumed it wasn't an exact duplicate so had applied the same fixes from the other one.

just copied to prepare for major changes.

Um, so I should make sure changes are duplicated between the files?

Jul 22 '24 08:07 jameshilliard

No you should not touch a file marked "to be changed" unless you want to change it as intended.

Jul 22 '24 19:07 janiversen

change it as intended.

How is it intended to be changed?

Jul 22 '24 20:07 jameshilliard

Read the issues, it will be integrated in framers.

Jul 22 '24 20:07 janiversen

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

Sep 06 '24 02:09 github-actions[bot]

This PR was closed because it has been stalled for 10 days with no activity.

Sep 16 '24 02:09 github-actions[bot]