pymmcore-plus icon indicating copy to clipboard operation
pymmcore-plus copied to clipboard

initial proof of concept cached events

Open simonecoppola opened this issue 1 year ago • 3 comments

simonecoppola avatar Nov 15 '24 12:11 simonecoppola

CodSpeed Performance Report

Merging #399 will not alter performance

Comparing simonecoppola:cached-events (c7971ad) with main (5d8d32c)

Summary

✅ 7 untouched benchmarks

codspeed-hq[bot] avatar Nov 15 '24 12:11 codspeed-hq[bot]

hey @simonecoppola, with the refactoring of sequencing done in #400 and other stuff, do you know if we could still benefit from caching here? Are you still doing something like this on your end? Happy to have something like this in here if there is benefit to be had

tlambert03 avatar Feb 07 '25 17:02 tlambert03

I haven't had a chance to test things further but from what I remember from the initial tests I did was that this was better performance wise, though I'm not sure why that would be the case as we're doing the same thing? It works quite well for us when running MDAs with basically zero gap between the various acquisitions, though I have just today discovered a pretty bad bug where after the MDA, if one starts a Live view, the system just keeps repeating the sequence😅 so it clearly needs some thinking/work...

I will do a few more tests to compare them and update you in the next few days!

simonecoppola avatar Feb 07 '25 20:02 simonecoppola