Medusa
Medusa copied to clipboard
pymedusa
'Jump to Season' Drop-Down Not Working
Describe the bug First, I have to say that I love the new pagination for long-lived shows with many episodes! Page loading has been vastly improved.
That said, there appears to be a problem with a huuuuuge show: the drop-down list to jump to a previous season doesn't seem to be working. If I select a previous season from the drop-down, the page stays on the current season. There doesn't appear to even be an attempt to re-load the page.
BTW, the Prev and Next buttons do appear to work.
To Reproduce Steps to reproduce the behaviour:
- Add 'Jeopardy' as a show. This show has about 37 seasons with over 200 episodes per season.
- Open the Show page.
- When the page has loaded, select a previous season from the 'Jump to Season' drop-down list.
- For me, there is no re-load of the page to show the requested season. I have even waited some time in case there's some background loading/processing going on for huge shows... it makes no difference (30+ minutes).
Expected behavior I expect the page to re-load, and display the season I selected.
Medusa (please complete the following information):
- OS: Windows-7-6.1.7601-SP1
- Branch: master
- Commit: d0c136d7a528a471b51676140bd35d24d97f65c6
- Python version: 3.7.3 (v3.7.3:ef4ec6ed12, Mar 25 2019, 22:22:05) [MSC v.1916 64 bit (AMD64)]
- Database version: 44.14
Debug logs (at least 50 lines): No log entries appear to be generated for this event.
Additional context I checked out some other long-lived shows, and found that this isn't confined just to the drop-down.
As an example, 'Dr. Who' has had only 12 seasons. Instead of a drop-down, this has a horizontal list of season numbers. Clicking on a previous season number exhibits the same incorrect behaviour as the drop-down list (i.e.: noting happens)! Again, the Prev and Next buttons do work.
I have no way of knowing for sure if all the seasons have loaded, but I have waited well over an hour and this behaviour doesn't change. I would expect even Jeopardy would be fully loaded by then. If I recall correctly, before the pagination improvement, Jeopardy would take about 10 minutes to load.
I did some more testing with Dr. Who (it's smaller and easier to work with).
The initial page shows Seasons 8 through 12, plus one episode of Season 7.
If I click on Season 4 in the horizontal season links at the top, nothing happens (not even a page re-load). Remember, this is after waiting over an hour for all background loading to finish.
If I hover over the season 4 link, the URL for this link is: http://localhost:8081/home/displayShow?indexername=tvdb&seriesid=78804#season-4
If I manually load this URL by hitting ENTER while in the address bar, it does not refresh the page, there is no re-load, and the page doesn't change (still shows S12 to S08). If I refresh the page with the browser's reload button, it does re-load, but still displays the initial page (in spite of the URL). If I open a new browser tab, and paste this URL into the address bar, the original first page with S12 to S08 loads. It appears that this URL with an appended anchor name doesn't work!
I checked this for Jeopardy, and noted the same behaviour. When I click on a season in the drop-down, the URL in the browser address bar changes to append "#season-xx", but the page doesn't re-load or change. These anchor names just don't seem to work!
As I said in my post, the Prev and Next buttons do work (from this I assume that the seasons have loaded).
If I use the Next button on Dr. Who, the page does re-load, and displays the remainder of S07, all of s06 & s05, and part of S04. I can continue using the Next button to move through all of the early seasons and the entire list of specials. The Prev button moves me back through these pages.
BTW, while the Prev and Next buttons re-load and refresh the page with new (and correct) content, the URL in the browser's address bar never changes.
@eddywitkamp said, "The jump will only work with pagination DISABLED"
I tested, and found this to be true. HOWEVER, this, in my opinion, is not useful behaviour. I thought the whole point of pagination was to enable huge show pages (i.e.: many seasons and/or episodes per season) to display faster. If you have to turn this OFF to jump to previous seasons, it seems a bit self-defeating.
I tried this with Jeopardy! Firstly, with pagination OFF, it took over an hour for all the seasons to finish loading! Remember that this show has 36 seasons of over 200 episodes each – that's a huge number of total episodes! Then, yes, you can select an earlier season from the jump list, and wait awhile for it to load. This is so wait intensive as to be virtually unusable.
The reason this came up was that I was trying to access the Specials. These are always at the bottom of all the episodes, so this was very trying. If I had kept pagination ON, I could have gotten there by repeatedly clicking on Next, but I'd have to do this 140 times!
OK... so apart from a critique, can I offer a solution?
Obviously, I'm not familiar with the code or structure of the program, but functionally I can see these as possibilities:
- It appears that when you fist display a show page, the program pulls the data for the current season, and renders a season/episode list. It then repeats this for each season going back to the first, and then for specials (if any). If this is the case, then if I click on a given season in the jump list, why not re-load the page, and start rendering from the selected season on down. There may be side effects with the Prev button, but perhaps this could be disabled once you choose to use the jump list.
- The most common reason that I, and probably others, want to dig down to earlier seasons is to access the specials. So, as a compromise, what about a quick way of accessing the Specials similar to above. A link called Specials could render a separate page that just displays the specials.
Just my $0.02, and some food for thought. Thank you all for your hard work developing this amazing piece of software!
The jumping should work and be made more smart. Also I was thinking handling the specials as a separate table. So it would always be at the bottom. Excluded from pagination. But only when enabled of course
Excellent news! If both of these are implemented, the new pagination feature will be a significant improvement. Thank you.
