CausalPy icon indicating copy to clipboard operation
CausalPy copied to clipboard

automate UML diagrams

Open williambdean opened this issue 1 year ago • 11 comments

Closes #178


📚 Documentation preview 📚: https://causalpy--395.org.readthedocs.build/en/395/

williambdean avatar Jul 30 '24 15:07 williambdean

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.35%. Comparing base (77058ee) to head (59a4624). Report is 141 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #395      +/-   ##
==========================================
+ Coverage   85.60%   94.35%   +8.75%     
==========================================
  Files          22       30       +8     
  Lines        1716     1967     +251     
==========================================
+ Hits         1469     1856     +387     
+ Misses        247      111     -136     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 30 '24 15:07 codecov[bot]

Where does the pyreverse command come from? pylint, right? Is this part of either the environment or pyproject dependencies?

EDIT: Added to docs

williambdean avatar Aug 01 '24 07:08 williambdean

pre-commit.ci autofix

williambdean avatar Aug 01 '24 08:08 williambdean

Having some permission issues. Not sure what is up @drbenvincent Might have to alter the pymc-marketing one as well

williambdean avatar Aug 01 '24 08:08 williambdean

@drbenvincent do you allow bots in the code base? I am noticing that the precommit auto fix didnt make a commit either

williambdean avatar Aug 02 '24 05:08 williambdean

Can you check in https://github.com/pymc-labs/CausalPy/settings/actions that "Workflow permissions" include "Read and write permissions" @drbenvincent

williambdean avatar Aug 03 '24 17:08 williambdean

Sorry for delay. Will focus on this ASAP.

drbenvincent avatar Aug 05 '24 16:08 drbenvincent

Had some issues in pymc marketing https://github.com/pymc-labs/pymc-marketing/pull/913

williambdean avatar Aug 05 '24 20:08 williambdean

Can you check in https://github.com/pymc-labs/CausalPy/settings/actions that "Workflow permissions" include "Read and write permissions" @drbenvincent

Current settings are as below. Let me know if I need to update anything. Screenshot 2024-08-06 at 20 28 35

drbenvincent avatar Aug 06 '24 19:08 drbenvincent

Can you check in https://github.com/pymc-labs/CausalPy/settings/actions that "Workflow permissions" include "Read and write permissions" @drbenvincent

Current settings are as below. Let me know if I need to update anything. Screenshot 2024-08-06 at 20 28 35

Thanks for checking this @drbenvincent

I was able to figure it out. Based on it coming from a fork.

Waiting for passing then can add back commented code

williambdean avatar Aug 22 '24 22:08 williambdean

Thoughts on the options: Run only on:

  1. on all pushes, if the repo owner is pymc-labs (not run during forks) but then also on merge to main
  2. merge to main

In either way, it will be updated.

What are your thoughts?

Here is the other option: https://github.com/pymc-labs/pymc-marketing/pull/967#issuecomment-2305913937

williambdean avatar Aug 22 '24 23:08 williambdean

This has deviated a bit from how it is (tried) to be done in PyMC-Marketing:

  • file: https://github.com/pymc-labs/pymc-marketing/blob/main/.github/workflows/uml.yml
  • runs: https://github.com/pymc-labs/pymc-marketing/actions/runs/13497681727

williambdean avatar Feb 28 '25 14:02 williambdean