CausalPy icon indicating copy to clipboard operation
CausalPy copied to clipboard

Add plots to docstrings of experiment classes

Open drbenvincent opened this issue 1 year ago • 9 comments

NOTE: We are just about to have a major refactor of the codebase, so this should be done after #381 is merged.

It might be nice to make the api docs (auto build from the docstrings) more engaging by adding some plots. As far as I can tell, it is possible to take the code that we have in the doctests right now and also generate a plot that is rendered in the docs.

This could be relevant for the experiment classes in particular. I don't see any value in adding to the model classes for example.

Here's an example of current docs: Screenshot 2024-07-12 at 20 32 53

If we add the plot method into that code snippet, then we can get that plot to render in the built docs.

I believe (though have not verified) that we can do this as follows:

.. plot::
    :context: close-figs
    :include-source: True
    :format: doctest

    >>> import causalpy as cp
    >>> df = cp.load_data("did")
    >>> seed = 42
    >>> result = cp.pymc_experiments.DifferenceInDifferences(
    ...     df,
    ...     formula="y ~ 1 + group*post_treatment",
    ...     time_variable_name="t",
    ...     group_variable_name="group",
    ...     model=cp.pymc_models.LinearRegression(
    ...         sample_kwargs={
    ...             "target_accept": 0.95,
    ...             "random_seed": seed,
    ...             "progressbar": False,
    ...         }
    ...     )
    ...  )
    >>> result.plot()

If that works as I imagine, then this will:

  • work as a doctest
  • render the code in the docs
  • include the rendered plot in the docs.

I have not verified that this works, but I imagine there is a way!

Notes

  1. We might need to call plt.show() at the end.
  2. At this point I have no idea if the doctest work would be taken over by sphinx, because there is an extension sphinx.ext.doctest. Would need to look into this.
  3. We'd also need to add sphinx.ext.plot_directive to the list of extensions in conf.py.

drbenvincent avatar Jul 12 '24 19:07 drbenvincent

Hey @drbenvincent, Can I pick this issue?

harsha-mangena avatar Jul 12 '24 23:07 harsha-mangena

Hi @harsha-mangena. Sounds good - but we're just about to merge a PR which is a pretty major code refactor. So we need to wait until #381 is merged first or any work done will be messed up. Can you check back toward the end of next week? It should (hopefully) be merged then.

drbenvincent avatar Jul 13 '24 00:07 drbenvincent

@drbenvincent, No problem. I will check this issue next week.

harsha-mangena avatar Jul 13 '24 00:07 harsha-mangena

Just a quick ping on this @harsha-mangena to see if you were still interested on working on this issue?

drbenvincent avatar Oct 11 '24 08:10 drbenvincent

Hey, if there's no progress on this issue, can I try working on it?

ahaan1984 avatar Oct 25 '24 16:10 ahaan1984

Hi, I am trying to build the docs locally by following the contribution guidelines, but whenever I try to run make html, I get this error:

Running Sphinx v8.1.3

Configuration error:
config directory doesn't contain a conf.py file (E:\causalpy\CausalPy\docs)

I've created the environment and followed the steps as mentioned in the guidelines. Would really appreciate it if I'd get some help in solving this.

ahaan1984 avatar Nov 01 '24 19:11 ahaan1984

Quick response for the moment...

When you run that command are you in the causalpy/docs folder?

drbenvincent avatar Nov 01 '24 19:11 drbenvincent

Yes, I'm running the command from the docs folder.

ahaan1984 avatar Nov 02 '24 04:11 ahaan1984

Any update with regards to the issue?

ahaan1984 avatar Nov 08 '24 09:11 ahaan1984