pytensor icon indicating copy to clipboard operation
pytensor copied to clipboard

Adds functions to rewrite cholesky decomposition of identity and diagonal matrices

Open tanish1729 opened this issue 1 year ago • 2 comments

Description

Add a function to rewrite cholesky(eye) -> eye and cholesky(diag) -> sqrt(diag)

Related Issue

  • [ ] Related to #573

Checklist

Type of change

  • [ ] New feature / enhancement
  • [ ] Bug fix
  • [ ] Documentation
  • [ ] Maintenance
  • [ ] Other (please specify):

tanish1729 avatar Jul 12 '24 06:07 tanish1729

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.76%. Comparing base (3e98b9f) to head (cf87362). Report is 91 commits behind head on main.

Files with missing lines Patch % Lines
pytensor/tensor/rewriting/linalg.py 93.93% 1 Missing and 1 partial :warning:
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #925   +/-   ##
=======================================
  Coverage   81.75%   81.76%           
=======================================
  Files         183      183           
  Lines       47763    47796   +33     
  Branches    11619    11635   +16     
=======================================
+ Hits        39050    39081   +31     
+ Misses       6523     6522    -1     
- Partials     2190     2193    +3     
Files with missing lines Coverage Δ
pytensor/tensor/rewriting/linalg.py 90.93% <93.93%> (+0.29%) :arrow_up:

... and 2 files with indirect coverage changes

codecov[bot] avatar Jul 12 '24 07:07 codecov[bot]

@jessegrabowski @ricardoV94

tanish1729 avatar Jul 21 '24 10:07 tanish1729

@jessegrabowski these PRs were missing labels, specially for the automatic release notes :(

ricardoV94 avatar Nov 08 '24 20:11 ricardoV94