pytensor icon indicating copy to clipboard operation
pytensor copied to clipboard

Implement linear algebra functions in PyTorch

Open twaclaw opened this issue 1 year ago • 1 comments

Description

Implemented:

  • BlockDiagonal
  • Cholesky
  • Eigvalsh
  • Solve
  • SolveTriangular

Related Issue

  • [ ] Closes #
  • [x] Related to #821

Checklist

Type of change

  • [x] New feature / enhancement
  • [ ] Bug fix
  • [ ] Documentation
  • [ ] Maintenance
  • [ ] Other (please specify):

twaclaw avatar Jul 11 '24 17:07 twaclaw

Codecov Report

Attention: Patch coverage is 66.66667% with 17 lines in your changes missing coverage. Please review.

Project coverage is 81.73%. Comparing base (117f80d) to head (4067a87).

Files with missing lines Patch % Lines
pytensor/link/pytorch/dispatch/slinalg.py 66.00% 16 Missing and 1 partial :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #922      +/-   ##
==========================================
- Coverage   81.74%   81.73%   -0.02%     
==========================================
  Files         183      184       +1     
  Lines       47740    47791      +51     
  Branches    11616    11623       +7     
==========================================
+ Hits        39027    39061      +34     
- Misses       6520     6534      +14     
- Partials     2193     2196       +3     
Files with missing lines Coverage Δ
pytensor/link/pytorch/dispatch/__init__.py 100.00% <100.00%> (ø)
pytensor/link/pytorch/dispatch/slinalg.py 66.00% <66.00%> (ø)

... and 2 files with indirect coverage changes

codecov[bot] avatar Jul 11 '24 18:07 codecov[bot]

@twaclaw can you rebase the PR to solve the conflicts. And if you addressed @jessegrabowski feel free to mark the comments as resolved for us to see if there's anything left to be addressed.

Let us know if you are not available. And thanks in advance!

ricardoV94 avatar Oct 03 '24 09:10 ricardoV94

@twaclaw can you rebase the PR to solve the conflicts. And if you addressed @jessegrabowski feel free to mark the comments as resolved for us to see if there's anything left to be addressed.

Let us know if you are not available. And thanks in advance!

Will do shortly, I was indeed not available for the last month or so but I am back now.

twaclaw avatar Oct 03 '24 11:10 twaclaw