pytensor icon indicating copy to clipboard operation
pytensor copied to clipboard

Refactor stacking functions, add dstack and column_stack

Open HarshvirSandhu opened this issue 1 year ago • 3 comments

Description

  1. Add dstack and column_stack for stacking tensors.
  2. Refactor function names
    • horizontal_stack to hstack
    • vertical_stack to vstack

Related Issue

  • [x] Closes #585

Type of change

  • [x] New feature / enhancement
  • [ ] Bug fix
  • [ ] Documentation
  • [x] Maintenance
  • [ ] Other (please specify):

HarshvirSandhu avatar Feb 04 '24 07:02 HarshvirSandhu

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (082081a) 80.80% compared to head (d160f9f) 80.82%. Report is 13 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #624      +/-   ##
==========================================
+ Coverage   80.80%   80.82%   +0.02%     
==========================================
  Files         162      162              
  Lines       46743    46765      +22     
  Branches    11419    11423       +4     
==========================================
+ Hits        37770    37798      +28     
+ Misses       6731     6721      -10     
- Partials     2242     2246       +4     
Files Coverage Δ
pytensor/tensor/basic.py 88.17% <82.14%> (-0.15%) :arrow_down:

... and 1 file with indirect coverage changes

codecov-commenter avatar Feb 04 '24 07:02 codecov-commenter

@ricardoV94 @jessegrabowski Is there anything else needed for this PR?

HarshvirSandhu avatar Feb 18 '24 05:02 HarshvirSandhu

@ricardoV94 Is there anything else needed for this PR?

HarshvirSandhu avatar Apr 21 '24 18:04 HarshvirSandhu