pytensor
pytensor copied to clipboard
ENH: Add destructive rewrites for Cholesky `Op`
Before
No response
After
No response
Context for the issue:
Currently, the Cholesky Op does not act in-place. This is a known problem since the Theano days (see comment here). We should:
- Add a rewrite that will set
destructive=Trueto cholesky nodes, - Add a destroy_map to Cholesky nodes
- Register the rewrite somewhere after the specialization step (this is done by other destructive rewrites, e.g. for
GEMV.
If anyone knows other linear algebra Ops that are not acting in-place, this issue could also collect those (SolveTriangular?)