pytensor icon indicating copy to clipboard operation
pytensor copied to clipboard

Add object mode fallback for Numba RandomVariables

Open twiecki opened this issue 9 months ago • 2 comments

Fixes https://github.com/pymc-devs/pytensor/issues/1245\n\nSummary:\n- When a RandomVariable is not implemented in Numba, it now gracefully falls back to object mode.\n- Added tests to verify that unsupported RandomVariables correctly trigger the object mode fallback.\n- This update ensures a smoother degradation experience and improves testing coverage.\n\nCloses #1245\n\nTest Plan:\n- Run the test suite using pytest to ensure no regressions occur.\n\nAcknowledgements:\n- Thanks to ricardoV94 for the feedback and review comments.

twiecki avatar Feb 26 '25 10:02 twiecki

Would be good if it referenced the original issues (there's a PR template you could tell it to fill). We shouldn't use it for beginner friendly issues, that's the point of marking them as beginner friendly? Fine if you're just testing.

I would be much more excited if it tackled docs issues. Like ask it to fix and finish the PR related to: #292 , #830

ricardoV94 avatar Feb 26 '25 11:02 ricardoV94

Top post does not include Related to or Closes #

Edit: I repeated myself

ricardoV94 avatar Feb 26 '25 15:02 ricardoV94