pymc4 icon indicating copy to clipboard operation
pymc4 copied to clipboard

Avoid vectorizing num_chain=1

Open junpenglao opened this issue 3 years ago • 4 comments

Close #317

junpenglao avatar Aug 30 '20 17:08 junpenglao

LGTM, do we want to copy in the MRE from #317 as a test?

kyleabeauchamp avatar Aug 30 '20 17:08 kyleabeauchamp

I'm not super aware of possible side effects of this change though, so someone else probably needs approve.

kyleabeauchamp avatar Aug 30 '20 17:08 kyleabeauchamp

Codecov Report

Merging #318 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #318   +/-   ##
=======================================
  Coverage   90.89%   90.89%           
=======================================
  Files          36       36           
  Lines        2822     2822           
=======================================
  Hits         2565     2565           
  Misses        257      257           
Impacted Files Coverage Δ
pymc4/mcmc/samplers.py 93.57% <100.00%> (ø)

codecov[bot] avatar Aug 30 '20 17:08 codecov[bot]

Filed an issue on TFP https://github.com/tensorflow/probability/issues/1071

junpenglao avatar Aug 30 '20 20:08 junpenglao