pymc icon indicating copy to clipboard operation
pymc copied to clipboard

Fix domain specification docstrings of ordered distributions

Open ricardoV94 opened this issue 1 year ago • 5 comments

Comment from https://github.com/pymc-devs/pymc/pull/7457#issuecomment-2317733942

This shouldn't be in discrete.rst but in the docs of the OrderedLogistic/Probit functions. image

Also as @AllenDowney mentioned the description of the distributions are themselves wrong: https://github.com/pymc-devs/pymc/blob/d31301279776888c1540bfba890cba38ea250637/pymc/distributions/discrete.py#L1192

ricardoV94 avatar Aug 29 '24 13:08 ricardoV94

I would like to work on this issue its pretty straight forward

rahul3002 avatar Jan 02 '25 18:01 rahul3002

Hi, I would like to work on this

Sourabh-Kumar7 avatar Feb 28 '25 03:02 Sourabh-Kumar7

Anybody can work on it, just open a PR and link to it (after checking there's not already a PR)

ricardoV94 avatar Feb 28 '25 10:02 ricardoV94

Hi @ricardoV94 can you help me understand the issue,

is it that the note ' The OrderedLogistic and OrderedProbit distributions expect the observed values to be 0-based, i.e., they should range from 0 to K-1. Using 1-based indexing (like 1, 2, 3,...K) can result in errors' should not be in discrete.rst but in logs of OrderedLogistic and OrderedProbit instead of it being from (1 to K) right(which is what the current logs is)?

Pratz2005 avatar Mar 12 '25 04:03 Pratz2005

Hi, I’d love to work on this issue as my first contribution. Is it still available? If so, I’d like to start working on it!

AtulBoyal avatar Mar 14 '25 17:03 AtulBoyal