pymc icon indicating copy to clipboard operation
pymc copied to clipboard

Extend `gp.Latent` to multi-outputs

Open hchen19 opened this issue 10 months ago • 5 comments

Description

add an argument n_outputs to gp.Latnet class with default value = 1

Related Issue

  • [x] Related to #7152

Checklist

Type of change

  • [x] New feature / enhancement
  • [ ] Bug fix
  • [ ] Documentation
  • [ ] Maintenance
  • [ ] Other (please specify):

📚 Documentation preview 📚: https://pymc--7226.org.readthedocs.build/en/7226/

hchen19 avatar Mar 28 '24 10:03 hchen19

Thank You Banner] :sparkling_heart: Thanks for opening this pull request! :sparkling_heart: The PyMC community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines and filled in our pull request template to the best of your ability.

welcome[bot] avatar Mar 28 '24 10:03 welcome[bot]

thanks for picking this up!

bwengals avatar Mar 29 '24 00:03 bwengals

This is looking good, though I still need to check out your branch and make sure. It looks like pre-commit isn't happy though. This page should show you how to fix it. Once that's green we can trigger the tests.

bwengals avatar Apr 06 '24 22:04 bwengals

This is looking good, though I still need to check out your branch and make sure. It looks like pre-commit isn't happy though. This page should show you how to fix it. Once that's green we can trigger the tests.

I fixed the pre-commit issue

hchen19 avatar Apr 06 '24 23:04 hchen19

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.67%. Comparing base (034b9a4) to head (11e41da). Report is 104 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7226      +/-   ##
==========================================
- Coverage   92.29%   91.67%   -0.62%     
==========================================
  Files         101      102       +1     
  Lines       16892    21739    +4847     
==========================================
+ Hits        15590    19930    +4340     
- Misses       1302     1809     +507     
Files Coverage Δ
pymc/gp/gp.py 95.07% <100.00%> (+0.03%) :arrow_up:

... and 37 files with indirect coverage changes

codecov[bot] avatar Jun 02 '24 00:06 codecov[bot]

None of these tests fail locally for me, so that's probably coming from conflicts, since this PR is quite old. Gonna open a new one and close this one

AlexAndorra avatar Aug 22 '24 09:08 AlexAndorra

Ported to #7471

AlexAndorra avatar Aug 22 '24 09:08 AlexAndorra

couldve swore I approved and merged this... my fault!

bwengals avatar Aug 23 '24 17:08 bwengals