pymc
pymc copied to clipboard
Extend `gp.Latent` to multi-outputs
Description
add an argument n_outputs
to gp.Latnet
class with default value = 1
Related Issue
- [x] Related to #7152
Checklist
- [x] Checked that the pre-commit linting/style checks pass
- [x] Included tests that prove the fix is effective or that the new feature works
- [x] Added necessary documentation (docstrings and/or example notebooks)
- [ ] If you are a pro: each commit corresponds to a relevant logical change
Type of change
- [x] New feature / enhancement
- [ ] Bug fix
- [ ] Documentation
- [ ] Maintenance
- [ ] Other (please specify):
📚 Documentation preview 📚: https://pymc--7226.org.readthedocs.build/en/7226/
]
:sparkling_heart: Thanks for opening this pull request! :sparkling_heart: The PyMC community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines and filled in our pull request template to the best of your ability.
thanks for picking this up!
This is looking good, though I still need to check out your branch and make sure. It looks like pre-commit isn't happy though. This page should show you how to fix it. Once that's green we can trigger the tests.
This is looking good, though I still need to check out your branch and make sure. It looks like pre-commit isn't happy though. This page should show you how to fix it. Once that's green we can trigger the tests.
I fixed the pre-commit issue
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.67%. Comparing base (
034b9a4
) to head (11e41da
). Report is 104 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #7226 +/- ##
==========================================
- Coverage 92.29% 91.67% -0.62%
==========================================
Files 101 102 +1
Lines 16892 21739 +4847
==========================================
+ Hits 15590 19930 +4340
- Misses 1302 1809 +507
Files | Coverage Δ | |
---|---|---|
pymc/gp/gp.py | 95.07% <100.00%> (+0.03%) |
:arrow_up: |
None of these tests fail locally for me, so that's probably coming from conflicts, since this PR is quite old. Gonna open a new one and close this one
Ported to #7471
couldve swore I approved and merged this... my fault!